Skip to content

Add py.typed marker for PEP 561 compliance#951

Open
arijitroy003 wants to merge 1 commit into
vllm-project:mainfrom
arijitroy003:fix/add-py-typed
Open

Add py.typed marker for PEP 561 compliance#951
arijitroy003 wants to merge 1 commit into
vllm-project:mainfrom
arijitroy003:fix/add-py-typed

Conversation

@arijitroy003

@arijitroy003 arijitroy003 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a py.typed marker file to enable type checkers to use the inline type hints already present in the package.

Changes

  • Created empty py.typed marker file in src/guidellm/
  • Updated pyproject.toml to include py.typed in package data

Testing

Verified by checking:

  • File exists in correct location (src/guidellm/py.typed)
  • Package data configuration includes the marker file

git log

commit 99d0de3
Author: arijitroy003 arijitroy003@gmail.com
Date: Thu Jul 23 20:30:00 2026 +0530

Add py.typed marker for PEP 561 compliance

Signed-off-by: arijitroy003 <arijitroy003@gmail.com>

Signed-off-by: arijitroy003 arijitroy003@gmail.com

Signed-off-by: arijitroy003 <arijitroy003@gmail.com>
@dbutenhof

Copy link
Copy Markdown
Collaborator

This is interesting -- I'd never heard of this protocol before, but it appears to be legit. On the other hand, our quality-checks run seems hung -- no indication there's any relationship to the change, and it's probably just GitHub... 🤔

@dbutenhof dbutenhof added this to the v0.8.0 milestone Jul 25, 2026

@dbutenhof dbutenhof left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a real thing; although I'm not sure what if anything actually depends on it, since it doesn't appear to affect our existing ruff lint/type checks.

@mergify

mergify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants